Skip to content

Commit 3ab83c7

Browse files
committed
Rename onSort() param
1 parent ffb065b commit 3ab83c7

File tree

18 files changed

+22
-22
lines changed

18 files changed

+22
-22
lines changed

src/routes/components/dataTable/expandableTable.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ interface ExpandableTableOwnProps {
2929
isActionsCell?: boolean;
3030
isAllExpanded?: boolean;
3131
isLoading?: boolean;
32-
onSort(value: string, isSortAscending: boolean);
32+
onSort(sortType: string, isSortAscending: boolean);
3333
orderBy: any;
3434
rows?: any[];
3535
selectedItems?: ComputedReportItem[];

src/routes/components/dataTable/selectableTable.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ interface SelectableTableOwnProps {
2424
emptyState?: ReactNode;
2525
filterBy: any;
2626
isLoading?: boolean;
27-
onSort(value: string, isSortAscending: boolean);
27+
onSort(sortType: string, isSortAscending: boolean);
2828
onRowClick(rowIndex: number);
2929
orderBy: any;
3030
rows?: any[];

src/routes/details/awsBreakdown/instances/instancesTable.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ interface InstancesTableOwnProps {
2121
isAllSelected?: boolean;
2222
isLoading?: boolean;
2323
onSelect(items: ComputedReportItem[], isSelected: boolean);
24-
onSort(value: string, isSortAscending: boolean);
24+
onSort(sortType: string, isSortAscending: boolean);
2525
orderBy?: any;
2626
query?: Query;
2727
report?: Report;
@@ -203,9 +203,9 @@ const InstancesTable: React.FC<InstancesTableProps> = ({
203203
);
204204
};
205205

206-
const handleOnSort = (value: string, isSortAscending: boolean) => {
206+
const handleOnSort = (sortType: string, isSortAscending: boolean) => {
207207
if (onSort) {
208-
onSort(value, isSortAscending);
208+
onSort(sortType, isSortAscending);
209209
}
210210
};
211211

src/routes/details/awsDetails/detailsTable.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ interface DetailsTableOwnProps extends RouterComponentProps, WrappedComponentPro
3333
isAllSelected?: boolean;
3434
isLoading?: boolean;
3535
onSelect(items: ComputedReportItem[], isSelected: boolean);
36-
onSort(value: string, isSortAscending: boolean);
36+
onSort(sortType: string, isSortAscending: boolean);
3737
orderBy?: any;
3838
query?: Query;
3939
report: AwsReport;

src/routes/details/azureDetails/detailsTable.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ interface DetailsTableOwnProps extends RouterComponentProps, WrappedComponentPro
3131
groupByTagKey?: string;
3232
isLoading?: boolean;
3333
onSelect(items: ComputedReportItem[], isSelected: boolean);
34-
onSort(value: string, isSortAscending: boolean);
34+
onSort(sortType: string, isSortAscending: boolean);
3535
orderBy?: any;
3636
query?: Query;
3737
report: AzureReport;

src/routes/details/components/pvcChart/modal/pvcTable.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { formatUsage, unitsLookupKey } from 'utils/format';
1313
interface PvcTableOwnProps {
1414
filterBy?: any;
1515
isLoading?: boolean;
16-
onSort(value: string, isSortAscending: boolean);
16+
onSort(sortType: string, isSortAscending: boolean);
1717
orderBy?: any;
1818
report: OcpReport;
1919
reportQueryString: string;
@@ -115,9 +115,9 @@ const PvcTable: React.FC<PvcTableProps> = ({ filterBy, isLoading, onSort, orderB
115115
setRows(filteredRows);
116116
};
117117

118-
const handleOnSort = (value: string, isSortAscending: boolean) => {
118+
const handleOnSort = (sortType: string, isSortAscending: boolean) => {
119119
if (onSort) {
120-
onSort(value, isSortAscending);
120+
onSort(sortType, isSortAscending);
121121
}
122122
};
123123

src/routes/details/gcpDetails/detailsTable.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ interface DetailsTableOwnProps extends RouterComponentProps, WrappedComponentPro
3131
isAllSelected?: boolean;
3232
isLoading?: boolean;
3333
onSelect(items: ComputedReportItem[], isSelected: boolean);
34-
onSort(value: string, isSortAscending: boolean);
34+
onSort(sortType: string, isSortAscending: boolean);
3535
orderBy?: any;
3636
query?: Query;
3737
report: GcpReport;

src/routes/details/ibmDetails/detailsTable.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ interface DetailsTableOwnProps extends RouterComponentProps, WrappedComponentPro
3131
isAllSelected?: boolean;
3232
isLoading?: boolean;
3333
onSelect(items: ComputedReportItem[], isSelected: boolean);
34-
onSort(value: string, isSortAscending: boolean);
34+
onSort(sortType: string, isSortAscending: boolean);
3535
orderBy?: any;
3636
query?: Query;
3737
report: IbmReport;

src/routes/details/ociDetails/detailsTable.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ interface DetailsTableOwnProps extends RouterComponentProps, WrappedComponentPro
3131
groupByTagKey?: string;
3232
isLoading?: boolean;
3333
onSelect(items: ComputedReportItem[], isSelected: boolean);
34-
onSort(value: string, isSortAscending: boolean);
34+
onSort(sortType: string, isSortAscending: boolean);
3535
orderBy?: any;
3636
query?: Query;
3737
report: OciReport;

src/routes/details/ocpDetails/detailsTable.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ interface DetailsTableOwnProps extends RouterComponentProps, WrappedComponentPro
4242
isLoading?: boolean;
4343
isRosToggleEnabled?: boolean;
4444
onSelect(items: ComputedReportItem[], isSelected: boolean);
45-
onSort(value: string, isSortAscending: boolean);
45+
onSort(sortType: string, isSortAscending: boolean);
4646
orderBy?: any;
4747
query?: Query;
4848
report: OcpReport;

src/routes/details/rhelDetails/detailsTable.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ interface DetailsTableOwnProps extends RouterComponentProps, WrappedComponentPro
3333
isAllSelected?: boolean;
3434
isLoading?: boolean;
3535
onSelect(items: ComputedReportItem[], isSelected: boolean);
36-
onSort(value: string, isSortAscending: boolean);
36+
onSort(sortType: string, isSortAscending: boolean);
3737
orderBy?: any;
3838
query?: Query;
3939
report: RhelReport;

src/routes/explorer/explorerTable.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ interface ExplorerTableOwnProps extends RouterComponentProps, WrappedComponentPr
5555
isAllSelected?: boolean;
5656
isLoading?: boolean;
5757
onSelect(items: ComputedReportItem[], isSelected: boolean);
58-
onSort(value: string, isSortAscending: boolean, date: string);
58+
onSort(sortType: string, isSortAscending: boolean, date: string);
5959
perspective: PerspectiveType;
6060
query: Query;
6161
report: Report;

src/routes/settings/costCategory/costCategoryTable.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ interface CostCategoryTableOwnProps {
1212
filterBy?: any;
1313
isLoading?: boolean;
1414
onSelect(items: SettingsData[], isSelected: boolean);
15-
onSort(value: string, isSortAscending: boolean);
15+
onSort(sortType: string, isSortAscending: boolean);
1616
orderBy?: any;
1717
selectedItems?: SettingsData[];
1818
settings: Settings;

src/routes/settings/platformProjects/platformProjectsTable.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ interface PlatformProjectsTableOwnProps {
1414
filterBy?: any;
1515
isLoading?: boolean;
1616
onSelect(items: SettingsData[], isSelected: boolean);
17-
onSort(value: string, isSortAscending: boolean);
17+
onSort(sortType: string, isSortAscending: boolean);
1818
orderBy?: any;
1919
selectedItems?: SettingsData[];
2020
settings: Settings;

src/routes/settings/tagLabels/tagMapping/components/childTags/childTagsTable.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ interface ChildTagsTableOwnProps {
1212
isAllSelected?: boolean;
1313
isLoading?: boolean;
1414
onSelect(items: SettingsData[], isSelected: boolean);
15-
onSort(value: string, isSortAscending: boolean);
15+
onSort(sortType: string, isSortAscending: boolean);
1616
orderBy?: any;
1717
selectedItems?: SettingsData[];
1818
settings: Settings;

src/routes/settings/tagLabels/tagMapping/components/parentTags/parentTagsTable.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ interface ParentTagsTableOwnProps {
1111
filterBy?: any;
1212
isLoading?: boolean;
1313
onSelect(items: SettingsData[], isSelected: boolean);
14-
onSort(value: string, isSortAscending: boolean);
14+
onSort(sortType: string, isSortAscending: boolean);
1515
orderBy?: any;
1616
selectedItems?: SettingsData[];
1717
settings: Settings;

src/routes/settings/tagLabels/tagMapping/tagMappingTable.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ interface TagMappingTableOwnProps {
1616
isDisabled?: boolean;
1717
isLoading?: boolean;
1818
onClose?: () => void;
19-
onSort(value: string, isSortAscending: boolean);
19+
onSort(sortType: string, isSortAscending: boolean);
2020
orderBy?: any;
2121
settings: Settings;
2222
}

src/routes/settings/tagLabels/tags/tagsTable.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ interface TagsTableOwnProps {
1212
filterBy?: any;
1313
isLoading?: boolean;
1414
onSelect(items: SettingsData[], isSelected: boolean);
15-
onSort(value: string, isSortAscending: boolean);
15+
onSort(sortType: string, isSortAscending: boolean);
1616
orderBy?: any;
1717
selectedItems?: SettingsData[];
1818
settings: Settings;

0 commit comments

Comments
 (0)