Skip to content

Commit 5b01c24

Browse files
authored
Merge pull request #4141 from dlabrecq/tags
Group-by should refresh with dateRange selection
2 parents 085d3ee + 1e8432c commit 5b01c24

File tree

9 files changed

+15
-2
lines changed

9 files changed

+15
-2
lines changed

src/routes/components/groupBy/groupBy.tsx

+7-2
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import { GroupByOrg } from './groupByOrg';
3030
import { GroupBySelect } from './groupBySelect';
3131

3232
interface GroupByOwnProps extends RouterComponentProps, WrappedComponentProps {
33+
dateRangeType?: string;
3334
endDate?: string;
3435
getIdKeyForGroupBy: (groupBy: Query['group_by']) => string;
3536
groupBy?: string;
@@ -122,8 +123,12 @@ class GroupByBase extends React.Component<GroupByProps, GroupByState> {
122123
}
123124

124125
public componentDidUpdate(prevProps: GroupByProps) {
125-
const { groupBy, perspective } = this.props;
126-
if (prevProps.groupBy !== groupBy || prevProps.perspective !== perspective) {
126+
const { dateRangeType, groupBy, perspective } = this.props;
127+
if (
128+
prevProps.groupBy !== groupBy ||
129+
prevProps.perspective !== perspective ||
130+
prevProps.dateRangeType !== dateRangeType
131+
) {
127132
let options;
128133
if (prevProps.perspective !== perspective) {
129134
options = {

src/routes/details/awsDetails/detailsHeader.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@ class DetailsHeaderBase extends React.Component<DetailsHeaderProps, any> {
157157
<Flex style={isAccountInfoDetailsToggleEnabled ? undefined : styles.perspective}>
158158
<FlexItem>
159159
<GroupBy
160+
dateRangeType={currentDateRangeType}
160161
getIdKeyForGroupBy={getIdKeyForGroupBy}
161162
groupBy={groupBy}
162163
isDisabled={!showContent}

src/routes/details/azureDetails/detailsHeader.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ class DetailsHeaderBase extends React.Component<DetailsHeaderProps, any> {
141141
<Flex>
142142
<FlexItem style={isAccountInfoDetailsToggleEnabled ? undefined : styles.perspective}>
143143
<GroupBy
144+
dateRangeType={currentDateRangeType}
144145
getIdKeyForGroupBy={getIdKeyForGroupBy}
145146
groupBy={groupBy}
146147
isDisabled={!showContent}

src/routes/details/gcpDetails/detailsHeader.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ class DetailsHeaderBase extends React.Component<DetailsHeaderProps, any> {
142142
<Flex>
143143
<FlexItem style={isAccountInfoDetailsToggleEnabled ? undefined : styles.perspective}>
144144
<GroupBy
145+
dateRangeType={currentDateRangeType}
145146
getIdKeyForGroupBy={getIdKeyForGroupBy}
146147
groupBy={groupBy}
147148
isDisabled={!showContent}

src/routes/details/ibmDetails/detailsHeader.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ class DetailsHeaderBase extends React.Component<DetailsHeaderProps, any> {
142142
<Flex>
143143
<FlexItem style={isAccountInfoDetailsToggleEnabled ? undefined : styles.perspective}>
144144
<GroupBy
145+
dateRangeType={currentDateRangeType}
145146
getIdKeyForGroupBy={getIdKeyForGroupBy}
146147
groupBy={groupBy}
147148
isDisabled={!showContent}

src/routes/details/ociDetails/detailsHeader.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ class DetailsHeaderBase extends React.Component<DetailsHeaderProps, any> {
141141
<Flex>
142142
<FlexItem style={isAccountInfoDetailsToggleEnabled ? undefined : styles.perspective}>
143143
<GroupBy
144+
dateRangeType={currentDateRangeType}
144145
getIdKeyForGroupBy={getIdKeyForGroupBy}
145146
groupBy={groupBy}
146147
isDisabled={!showContent}

src/routes/details/ocpDetails/detailsHeader.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,7 @@ class DetailsHeaderBase extends React.Component<DetailsHeaderProps, DetailsHeade
172172
<Flex style={isAccountInfoDetailsToggleEnabled ? undefined : styles.perspective}>
173173
<FlexItem>
174174
<GroupBy
175+
dateRangeType={currentDateRangeType}
175176
getIdKeyForGroupBy={getIdKeyForGroupBy}
176177
groupBy={groupBy}
177178
isDisabled={!showContent}

src/routes/details/rhelDetails/detailsHeader.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ class DetailsHeaderBase extends React.Component<DetailsHeaderProps> {
165165
<Flex>
166166
<FlexItem style={isAccountInfoDetailsToggleEnabled ? undefined : styles.perspective}>
167167
<GroupBy
168+
dateRangeType={currentDateRangeType}
168169
getIdKeyForGroupBy={getIdKeyForGroupBy}
169170
groupBy={groupBy}
170171
isDisabled={!showContent}

src/routes/explorer/explorerHeader.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,7 @@ class ExplorerHeaderBase extends React.Component<ExplorerHeaderProps, ExplorerHe
320320
<FlexItem>{this.getPerspective(noProviders)}</FlexItem>
321321
<FlexItem>
322322
<GroupBy
323+
dateRangeType={dateRangeType}
323324
endDate={endDate}
324325
getIdKeyForGroupBy={getIdKeyForGroupBy}
325326
groupBy={groupBy}

0 commit comments

Comments
 (0)