Skip to content

Commit a668187

Browse files
authored
Merge pull request #4062 from dlabrecq/cost-5596
Improve resource type search in Cost explorer
2 parents 856e57f + 9e70014 commit a668187

File tree

6 files changed

+7
-5
lines changed

6 files changed

+7
-5
lines changed

src/api/resources/awsOcpResource.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ import { ResourceType } from './resource';
55

66
test('runExport API request for OCP on AWS', () => {
77
runResource(ResourceType.account, '');
8-
expect(axiosInstance.get).toBeCalledWith('resource-types/aws-accounts/');
8+
expect(axiosInstance.get).toBeCalledWith('resource-types/aws-accounts/?openshift=true');
99
});

src/api/resources/awsOcpResource.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ export const ResourceTypePaths: Partial<Record<ResourceType, string>> = {
1515

1616
export function runResource(resourceType: ResourceType, query: string) {
1717
const path = ResourceTypePaths[resourceType];
18-
const queryString = query ? `?${query}` : '';
18+
const queryString = query ? `?openshift=true;${query}` : '?openshift=true';
1919
return axiosInstance.get<Resource>(`${path}${queryString}`);
2020
}

src/routes/components/resourceTypeahead/resourceInput.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ const ResourceInput: React.FC<ResourceInputProps> = ({
6464
onChange={onChange}
6565
onFocus={() => setIsOpen(true)}
6666
onKeyDown={handleOnTextInputKeyDown}
67+
onBlur={onClear}
6768
placeholder={placeholder}
6869
/>
6970
{search && search.length && (

src/routes/explorer/explorerFilter.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ export class ExplorerFilterBase extends React.Component<ExplorerFilterProps, Exp
130130
options.push({
131131
name: intl.formatMessage(messages.filterByValues, { value: option.label }),
132132
key: option.value,
133+
resourceKey: option.resourceKey,
133134
});
134135
});
135136
if (orgReport?.data?.length > 0) {

src/routes/explorer/explorerToolbar.tsx

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import type { ToolbarChipGroup } from '@patternfly/react-core';
21
import React from 'react';
32
import type { WrappedComponentProps } from 'react-intl';
43
import { injectIntl } from 'react-intl';
@@ -33,7 +32,7 @@ interface ExplorerToolbarDispatchProps {
3332
}
3433

3534
interface ExplorerToolbarState {
36-
categoryOptions?: ToolbarChipGroup[];
35+
// TBD...
3736
}
3837

3938
type ExplorerToolbarProps = ExplorerToolbarOwnProps &

src/routes/explorer/explorerUtils.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,9 @@ export const baseQuery: Query = {
5656
export const groupByAwsOptions: {
5757
label: string;
5858
value: ComputedAwsReportItemsParams['idKey'];
59+
resourceKey?: string;
5960
}[] = [
60-
{ label: 'account', value: 'account' },
61+
{ label: 'account', value: 'account', resourceKey: 'account_alias' },
6162
{ label: 'service', value: 'service' },
6263
{ label: 'region', value: 'region' },
6364
];

0 commit comments

Comments
 (0)