Skip to content

Replace remaining deprecated PatternFly Select component #3778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

dlabrecq
Copy link
Contributor

@dlabrecq dlabrecq commented Apr 10, 2024

Replace remaining deprecated PatternFly Select component.

Depends on PatternFly milestone #3753 -- must merge that for tests to pass

Closes https://issues.redhat.com/browse/COST-4585

@dlabrecq dlabrecq marked this pull request as draft April 10, 2024 15:29
@dlabrecq dlabrecq force-pushed the select branch 3 times, most recently from a0c7f1d to 105c495 Compare April 19, 2024 04:34
@dlabrecq dlabrecq force-pushed the select branch 4 times, most recently from c92732d to 28a9aaf Compare April 20, 2024 04:20
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 65.80%. Comparing base (d4ad600) to head (87bde8d).

Files Patch % Lines
.../costModels/costModelWizard/generalInformation.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3778      +/-   ##
==========================================
- Coverage   65.83%   65.80%   -0.04%     
==========================================
  Files         514      514              
  Lines        9932     9926       -6     
  Branches     2170     2327     +157     
==========================================
- Hits         6539     6532       -7     
+ Misses       3390     3150     -240     
- Partials        3      244     +241     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlabrecq dlabrecq marked this pull request as ready for review April 20, 2024 04:27
@dlabrecq dlabrecq merged commit a42316a into project-koku:main Apr 20, 2024
7 checks passed
@dlabrecq dlabrecq deleted the select branch April 20, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants