Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pipenv-setup in order to publish PEP 625 compliant sdist and wheel #541

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Mar 12, 2025

pipenv-setup depends on an older version of packaging which creates sdist and wheel files that do not comply with PEP 625. This results in the following notice from PyPI:

This email is notifying you of an upcoming deprecation that we have determined may affect you as a result of your recent upload to 'koku-nise'.
In the future, PyPI will require all newly uploaded source distribution filenames to comply with PEP 625. Any source distributions already uploaded will remain in place as-is and do not need to be updated.
Specifically, your recent upload of 'koku-nise-4.7.2.tar.gz' is incompatible with PEP 625 because it does not contain the normalized project name 'koku_nise'.
In most cases, this can be resolved by upgrading the version of your build tooling to a later version that supports PEP 625 and produces compliant filenames. You do not need to remove the file.

pipenv-setup seems abandoned as the last commit was almost three years ago.

Pipfile and setup.py serve different purposes. Keeping them in sync shouldn't necessarily be a goal. Pipfile.lock serves developers working on nise. setup.py requirements serve those installing the application for use.

Steps to duplicate the problem

> python3 -m pip install --force setuptools wheel twine chardet pipenv-setup vistir==0.6.1 -c requirements/build-constraints.txt
> python setup.py sdist bdist_wheel
> ls -1 dist
koku-nise-4.7.2.tar.gz
koku_nise-4.7.2-py3-none-any.whl

pipenv-setup requires an old version of packaging which prevents naming the
sdist and wheel in accordance with PEP 625.

The project seems abandanded as it has not had updates in more than three years.
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.7%. Comparing base (5aea935) to head (0e9492a).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #541   +/-   ##
=====================================
  Coverage   93.7%   93.7%           
=====================================
  Files         62      62           
  Lines       4663    4663           
  Branches     646     646           
=====================================
  Hits        4368    4368           
  Misses       158     158           
  Partials     137     137           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samdoran
Copy link
Contributor Author

This is obsoleted by #537 but may be a useful stopgap measure until #537 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant