Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate item panel IDs #3432

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Fix duplicate item panel IDs #3432

merged 1 commit into from
Feb 7, 2025

Conversation

taylor-steve
Copy link
Contributor

@taylor-steve taylor-steve commented Feb 7, 2025

Closes #3431.

Old format: st-block-2_item_[resource ID]
Screenshot 2025-02-06 at 9 39 52 AM

New format: st-block-2_item_[item's unique globalIndex]
Screenshot 2025-02-07 at 8 27 27 AM

I'm not seeing anywhere in Spotlight where we are depending on the particular format of these IDs and they are only used in the admin interface.

@taylor-steve taylor-steve marked this pull request as ready for review February 7, 2025 16:42
@corylown corylown merged commit 919cce5 into main Feb 7, 2025
6 checks passed
@corylown corylown deleted the 3431-duplicate-ids branch February 7, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Duplicate panel IDs for resource widget blocks
2 participants