Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(security): add ClamAV integration #436

Merged
merged 1 commit into from
Feb 19, 2024
Merged

feat(security): add ClamAV integration #436

merged 1 commit into from
Feb 19, 2024

Conversation

Yelinz
Copy link
Member

@Yelinz Yelinz commented Jan 26, 2024

This adds django_clamd for AV scanning capabilites with ClamAV.
The scanning can be enabled through the settings.

@anehx anehx force-pushed the clamd branch 3 times, most recently from 2a1f118 to aff186c Compare February 14, 2024 15:18
@Yelinz Yelinz force-pushed the clamd branch 4 times, most recently from ce34c84 to a896788 Compare February 19, 2024 11:28
@Yelinz Yelinz marked this pull request as ready for review February 19, 2024 11:28
@Yelinz Yelinz requested review from winged and fugal-dy February 19, 2024 11:28
Copy link
Contributor

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick about config defaults.

Also, for new features, I'd like to see a short description in the commit message and pull request to explain a bit more what it does. Generally I'd like to see less one-liners (this is not a personal feedback, just a general observation)

@Yelinz Yelinz changed the title feat: add clamd feat(security): add ClamAV integration Feb 19, 2024
Copy link
Contributor

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs should match code. And it's a pity the pyproject.toml got shuffled around, even though no actual change happend there despite the new dependency. Especially the coverage config which is entirely unrelated to this change.

@Yelinz Yelinz force-pushed the clamd branch 2 times, most recently from 3b46d2a to a9f0ba3 Compare February 19, 2024 16:12
This adds django_clamd for AV scanning capabilites with ClamAV.
The scanning can be enabled through the settings.
@Yelinz Yelinz merged commit fe314ca into main Feb 19, 2024
@Yelinz Yelinz deleted the clamd branch February 19, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants