feat(jexl): add main_case_form to info object #2204
Conversation
caluma/caluma_form/structure.py
Outdated
| if self._main_form is None: | ||
| if hasattr(self.document.family, "work_item") and hasattr( | ||
| self.document.family.work_item.case.family, "document" | ||
| ): |
There was a problem hiding this comment.
there's probably a cleaner way to do this in python?
There was a problem hiding this comment.
There's operator.attrgetter, but it doesn't make things much shorter.
Since the default/fallback is to just have *no value", you could just as well fetch the whole attribute chain and just try/except around it
caluma/caluma_form/structure.py
Outdated
| @property | ||
| def main_form(self): | ||
| if self._main_form is None: | ||
| if hasattr(self.document.family, "work_item") and hasattr( | ||
| self.document.family.work_item.case.family, "document" | ||
| ): | ||
| self._main_form = ( | ||
| self.document.family.work_item.case.family.document.form.slug | ||
| ) | ||
| return self._main_form |
There was a problem hiding this comment.
Two things: One, naming: I think it might be confusing, as the "main form" could also be the the main form of the current document, for example if you're in a row-doc or similar. Suggestion: "main_case_form" or something similar maybe?
Second: If for some reason the inner if does not find the main form, it will not cache the result in self._main_form and try to do the whole resolution-chain again, possibly triggering quite a few DB queries. I'd suggest caching that case as well
There was a problem hiding this comment.
Fixed the naming and caching 👍
czosel
changed the title
This is convenient when you'd like to write a JEXL expression in a task form attached to some work item, that depends on the main case's form.
This is convenient when you'd like to write a JEXL expression in a task form attached to some work item, that depends on the case's main documents' form.
Related PR in ember-caluma: projectcaluma/ember-caluma#2703
Once we merge this, we should spend a minute to update the caluma docs: https://caluma.gitbook.io/caluma-docs/forms/validation#variables-available-for-evaluation