feat(form): add more case info to jexl context #2205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czosel
commented
Apr 25, 2024
czosel
force-pushed
the
jexl-root-case
branch
2 times, most recently
from
4198a94 to
d972691
Compare
winged
requested changes
Apr 29, 2024
winged
approved these changes
Apr 29, 2024
czosel
commented
Apr 29, 2024
| @@ -49,6 +49,8 @@ def get(self, name, default=None): | |||
| out = out() | |||
| if isinstance(out, Element) or isinstance(out, dict): | |||
| return out | |||
| if out is None: | |||
| return None | |||
There was a problem hiding this comment.
@winged I still added coverage for the "disconnected document" case - I had to add this line to make it pass, because otherwise the returned value is the string "None" instead of null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in projectcaluma/ember-caluma#2703 (comment)