Skip to content

feat(options): implement is_hidden jexl on options #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

open-dynaMIX
Copy link
Member

This commit adds an is_hidden jexl to Options. This nwill be evaluated and enforced on saving of answers. Addiotionally, the Options got a new filter visible_in_document.

@open-dynaMIX open-dynaMIX force-pushed the is-hidden-jexl-on-options branch 4 times, most recently from 202424b to b23b9a1 Compare June 6, 2024 09:11
@open-dynaMIX open-dynaMIX force-pushed the is-hidden-jexl-on-options branch 2 times, most recently from 8fe7609 to c005980 Compare June 17, 2024 08:14
@open-dynaMIX open-dynaMIX marked this pull request as ready for review June 17, 2024 09:28
@open-dynaMIX open-dynaMIX requested a review from winged June 17, 2024 09:28
Copy link
Contributor

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! I have some suggestions regarding the filter docstring, but other than that, LGTM! Very nice

This commit adds an `is_hidden` jexl to Options. This nwill be evaluated
and enforced on saving of answers. Addiotionally, the Options got a new
filter `visible_in_document`.
@open-dynaMIX open-dynaMIX force-pushed the is-hidden-jexl-on-options branch from c005980 to 38ca1c4 Compare June 17, 2024 12:36
@winged winged merged commit bd9286a into projectcaluma:main Jun 17, 2024
24 checks passed
@open-dynaMIX open-dynaMIX deleted the is-hidden-jexl-on-options branch June 17, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants