refactor: download function #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yelinz
force-pushed
the
fix-download
branch
3 times, most recently
from
73b6d54 to
02f7374
Compare
Closed
|
conflicts :-/ |
refresh when downloadURL is expired extract download function from document-card
czosel
reviewed
Mar 21, 2024
|
LGTM for the rest, nice work! 💯 |
move download and error handler into utils
czosel
approved these changes
Mar 21, 2024
|
🎉 This PR is included in version 7.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refresh when downloadURL is expired
extract download function from document-card
This fix prevents serving expired download and webdav urls. A fresh webdav link is always fetched before opening as we dont know when it expires. The download url is parsed for expiry date and only refetched if its expired.
Also fixes the problem that after a replace the old file is still served.