Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(delete): delete concurrently and clean up correctly #771

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

Yelinz
Copy link
Member

@Yelinz Yelinz commented Apr 10, 2024

fixes bug when deleting multiple the last one keeps the side panel open, eventhough it does not exist anymore

and its 10x or so faster (promise.all ftw)

  • modal tests fail as always..

@Yelinz Yelinz requested review from StephanH90, anehx and czosel April 19, 2024 09:15
@Yelinz Yelinz self-assigned this Apr 29, 2024
fixes bug when deleting multiple the last one keeps the side panel open,
eventhough it does not exist anymore
@czosel czosel merged commit 0b412ad into main Apr 30, 2024
9 checks passed
@czosel czosel deleted the fix-delete branch April 30, 2024 12:32
@adfinisbot
Copy link
Collaborator

🎉 This PR is included in version 8.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants