Skip to content

feat(form): add case infos to jexl context #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2024
Merged

feat(form): add case infos to jexl context #2703

merged 2 commits into from
May 17, 2024

Conversation

czosel
Copy link
Contributor

@czosel czosel commented Apr 25, 2024

This is convenient when you'd like to write a JEXL expression in a task form attached to some work item, that depends on the case's main documents' form.

Related backend MRs:

@czosel czosel requested a review from anehx April 25, 2024 08:59
@czosel czosel force-pushed the jexl-case-main-form branch 3 times, most recently from a06af60 to 8e887d1 Compare April 25, 2024 09:04
@czosel czosel changed the title feat(form): add cases' main form to jexl context feat(form): add main cases' form to jexl context Apr 25, 2024
@czosel czosel requested a review from StephanH90 April 25, 2024 09:14
@czosel czosel force-pushed the jexl-case-main-form branch from 8e887d1 to 885634c Compare April 25, 2024 09:17
Copy link
Contributor

@StephanH90 StephanH90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question.

@StephanH90
Copy link
Contributor

Don't forget to rename the property once a decision is made but I will approve now.

@StephanH90
Copy link
Contributor

But the naming between the backend and the frontend doesn't match, does it?

In the backend we now have a main_case_form which would be the case.root.form in the frontend, correct?
(https://github.com/projectcaluma/caluma/pull/2204/files#diff-4200093d628340ea25db028f99d1543cb5c63af275a4a670a9c08adee6444effR150-R158)

Should we try to keep the naming consistent between frontend and backend?

@czosel
Copy link
Contributor Author

czosel commented Apr 30, 2024

But the naming between the backend and the frontend doesn't match, does it?

In the backend we now have a main_case_form which would be the case.root.form in the frontend, correct? (https://github.com/projectcaluma/caluma/pull/2204/files#diff-4200093d628340ea25db028f99d1543cb5c63af275a4a670a9c08adee6444effR150-R158)

Should we try to keep the naming consistent between frontend and backend?

The backend MR was merged a little bit too quickly, here is the follow-up which should line up with the frontend part: projectcaluma/caluma#2205

@czosel czosel force-pushed the jexl-case-main-form branch from b184c94 to dfa25c8 Compare May 14, 2024 08:06
@czosel czosel force-pushed the jexl-case-main-form branch from dfa25c8 to a7ec0a1 Compare May 14, 2024 08:12
@czosel
Copy link
Contributor Author

czosel commented May 14, 2024

@anehx I added another test for unlinked documents. Want to take another look?

@czosel czosel changed the title feat(form): add main cases' form to jexl context feat(form): add case infos to jexl context May 14, 2024
Copy link
Contributor

@anehx anehx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🚀

@czosel czosel merged commit 0e597c1 into main May 17, 2024
57 checks passed
@czosel czosel deleted the jexl-case-main-form branch May 17, 2024 08:54
@anehx
Copy link
Contributor

anehx commented May 17, 2024

🎉 This PR is included in version 12.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@anehx anehx added the released label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants