chore: drop related name on base model created_by_user

This caused, for example, on the `User` model to set an `acl`
attribute, pointing to the creator.

This is very confusing, for example if searching for all users within a scope:

>>> User.objects.filter(acl__scope__in=scope_list)

This would return the user who has *created* all those ACLs, instead of the
users who are in fact *granted* the ACL.

The correct way would have been

>>> User.objects.filter(acls__scope__in=scope_list)

So to avoid this confusion (and others), we'll remove the related name.

Author: winged

emeis/core/migrations/0013_drop_related_name.py

@@ -0,0 +1,64 @@
+# Generated by Django 3.2.25 on 2024-12-24 10:28
+
+from django.conf import settings
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("emeis_core", "0012_parents_as_arrayfield"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="acl",
+            name="created_by_user",
+            field=models.ForeignKey(
+                null=True,
+                on_delete=django.db.models.deletion.SET_NULL,
+                related_name="+",
+                to=settings.AUTH_USER_MODEL,
+            ),
+        ),
+        migrations.AlterField(
+            model_name="permission",
+            name="created_by_user",
+            field=models.ForeignKey(
+                null=True,
+                on_delete=django.db.models.deletion.SET_NULL,
+                related_name="+",
+                to=settings.AUTH_USER_MODEL,
+            ),
+        ),
+        migrations.AlterField(
+            model_name="role",
+            name="created_by_user",
+            field=models.ForeignKey(
+                null=True,
+                on_delete=django.db.models.deletion.SET_NULL,
+                related_name="+",
+                to=settings.AUTH_USER_MODEL,
+            ),
+        ),
+        migrations.AlterField(
+            model_name="scope",
+            name="created_by_user",
+            field=models.ForeignKey(
+                null=True,
+                on_delete=django.db.models.deletion.SET_NULL,
+                related_name="+",
+                to=settings.AUTH_USER_MODEL,
+            ),
+        ),
+        migrations.AlterField(
+            model_name="user",
+            name="created_by_user",
+            field=models.ForeignKey(
+                null=True,
+                on_delete=django.db.models.deletion.SET_NULL,
+                related_name="+",
+                to=settings.AUTH_USER_MODEL,
+            ),
+        ),
+    ]

emeis/core/models.py

@@ -36,7 +36,9 @@ def get_language_code():
 class BaseModel(models.Model):
     created_at = models.DateTimeField(auto_now_add=True, db_index=True)
     modified_at = models.DateTimeField(auto_now=True, db_index=True)
-    created_by_user = models.ForeignKey("User", null=True, on_delete=models.SET_NULL)
+    created_by_user = models.ForeignKey(
+        "User", null=True, on_delete=models.SET_NULL, related_name="+"
+    )
     metainfo = models.JSONField(_("metainfo"), default=dict)
 
     class Meta: