Make Collector labels-to-child map implementation pluggable #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prometheus#460 proposed an optimized zero-GC version of the child lookup logic which was deemed too specialized for inclusion in the library. Subjectively less complex alternatives were also proposed which provide some but not as much performance/garbage improvement, and rely for example on some per-thread overhead. This PR aims to add a minimally-invasive mechanism to allow users to plug in an implementation of their choice, so that performance sensitive consumers can opt for minimal overhead without the core library having to include the corresponding code. Signed-off-by: nickhill <nickhill@us.ibm.com>
njhill
force-pushed
the
pluggable-map
branch
from
c7790ed to
dfdd0b9
Compare
|
Thanks for your PR, I don't believe this sort of thing should be pluggable - that's asking for someone to make an incompatible implementation and causing problems down the line. We should have one implementation that works well such as proposed in #486, and if someone is in a particularly niche setup they can always create custom collectors. |
|
@brian-brazil the only "niche" aspect of my usage is the desire for minimal runtime overhead. I am using a few of the different standard collectors and so using custom ones will mean duplicating all of them which I was hoping to avoid but I guess is the only option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#460 proposed an optimized zero-GC version of the child lookup logic which was deemed too specialized for inclusion in the library.
Subjectively less complex alternatives were also proposed which provide some but not as much performance/garbage improvement, and rely for example on some per-thread overhead.
This PR aims to add a minimally-invasive mechanism to allow users to plug in an implementation of their choice, so that performance sensitive consumers can opt for minimal overhead without the core library having to include the corresponding code.