Migrate from pendulum to arrow for dates #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest implementation of pendulum is partially written in Rust. I've repeatedly had problems getting it to install properly as part of my Poetry development environment — especially when using Python 3.13 on Windows 10 and my M3 Macbook. Depending on the platform, there is apparently not always a binary wheel available, and then Poetry has to fall back on building one. That depends on a working Rust toolchain, which I typically don't have. I assume this might also be a problem for others who use apologies as a dependency. Given the very minimal usage of pendulum in this codebase, I've decided to remove it in favor of arrow.
Note: This is unfortunately a breaking change, since dates are exposed on the interface of
apologies.game. History. As a result, I bumped the version to v0.2.0. Because the previous major version was zero, we are subject to the SemVer exception, and it is legitimate to introduce breaking changes between 0.1.57 and 0.2.0. The old and new objects (arrow'sArrowand pendulum'sDateTime) have quite similar interfaces, and most clients can probably upgrade with no problems.