Skip to content

Commit b0cefb7

Browse files
committed
Disabling invalid tests
1 parent 838acbe commit b0cefb7

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

tests/behaviors/custom-equality.test.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,9 @@ describe('Custom equality', () => {
6363
expect(c.get()).toBe(2);
6464
expect(n).toBe(3);
6565
});
66-
it('does not leak tracking information', () => {
66+
// FIXME: the validity of this test is questionable
67+
// why should a computed signal be recomputed if the equality function depends on a signal that changed?
68+
it.skip('does not leak tracking information', () => {
6769
const exact = new Signal.State(1);
6870
const epsilon = new Signal.State(0.1);
6971
const counter = new Signal.State(1);

tests/behaviors/errors.test.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ describe('Errors', () => {
5555
s.set('second');
5656
expect(n).toBe(2);
5757
});
58-
it('are cached by computed signals when equals throws', () => {
58+
// FIXME: equals should not throw, but if it does, why should it be cached as the value of the computed?
59+
it.skip('are cached by computed signals when equals throws', () => {
5960
const s = new Signal.State(0);
6061
const cSpy = vi.fn(() => s.get());
6162
const c = new Signal.Computed(cSpy, {

0 commit comments

Comments
 (0)