Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up prettier #20

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

ds300
Copy link
Contributor

@ds300 ds300 commented Jun 20, 2024

I noticed this repo has prettier installed but not set up on CI so the file formatting is quite inconsistent. This makes it hard to work on if you are one of the many people who have prettier integrated in their editor/IDE because it keeps introducing unrelated formatting changes.

This PR

  • Configures prettier with angular's config since the signals code was originally forked from there. Happy to change this based on maintainer's preferences.
  • Runs prettier to bring all files up to date.
  • Adds a CI check to make sure the formatting remains consistent over time

Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@NullVoxPopuli NullVoxPopuli merged commit 1ec9d8e into proposal-signals:main Jun 24, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants