fix assignment of subtypes (#7) #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there a test that would fail before this change? |
|
yes, the tests added in this commit fail without these changes |
| @@ -93,3 +93,19 @@ expectTypeOf<keyof Signal.subtle.Watcher & string>().toEqualTypeOf< | |||
| expectTypeOf(new Signal.State(0)).toEqualTypeOf<Signal.State<number>>(); | |||
| expectTypeOf(new Signal.State(0).get()).toEqualTypeOf<number>(); | |||
| expectTypeOf(new Signal.State(0).set(1)).toEqualTypeOf<void>(); | |||
|
|
|||
| /** | |||
| * Assigning subtypes works | |||
There was a problem hiding this comment.
thanks for adding these tests!
NullVoxPopuli
approved these changes
Jan 17, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is also an alternative solution - not to introduce a new interface.
Then need to change all the
equaldeclarations from a property to a method, but it doesn't look elegant.equal(...args: Parameters<ValueEqualityFn<T>>): ReturnType<ValueEqualityFn<T>>;