Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Z3 Optimize: add assert_and_track and get_unsat_core #300

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Z3 Optimize: add assert_and_track and get_unsat_core #300

merged 5 commits into from
Jun 25, 2024

Conversation

toolCHAINZ
Copy link
Contributor

I noticed these are missing from Optimize and would have some use for them.

waywardmonkeys
waywardmonkeys requested changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me apart from the comment… would it be easy to add a test for this?

@toolCHAINZ
Copy link
Contributor Author

Looks good to me apart from the comment… would it be easy to add a test for this?

Ok, I've added a test that exercises both assert_and_track + check and an individual check.

@waywardmonkeys
Copy link
Contributor

Ok, I've added a test that exercises both assert_and_track + check and an individual check.

Great, thanks!

@waywardmonkeys waywardmonkeys merged commit c126e07 into prove-rs:master Jun 25, 2024
11 checks passed
@toolCHAINZ toolCHAINZ mentioned this pull request Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waywardmonkeys waywardmonkeys Awaiting requested review from waywardmonkeys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toolCHAINZ @waywardmonkeys