Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unhandled events #139

Merged
merged 6 commits into from
Nov 18, 2021
Merged

Add unhandled events #139

merged 6 commits into from
Nov 18, 2021

Conversation

mathisloevenich
Copy link
Collaborator

@mathisloevenich mathisloevenich commented Nov 17, 2021

fixes partly #127

Within the testset of ukb, enki and git htcondor logs, all events are handled.

The problem is that the documentation about how to access address each event individually is missing and there is no python baseclass to extract the information from. From what I understand is that the python structure is translated directly from the C++ base module, which has a total different setup and makes it hard to known where which part of the information is comming from.

Each event has a different struture which means each event needs to be handled differently.

There are base classes for the following event numbers that come with this PR:

  • 000 - 013
  • 022, 023, 024

Not (yet) handled events (regarding the base classes) are:

  • 008 (does not do anything)
  • 010 job suspended (no test data)
  • 011 job unsuspended (no test data)
  • 013 job released (no test data)
  • 023 job reconnected (no test data)

And obviously all other events not mentioned here need also to be implemented

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2021

Codecov Report

Merging #139 (e034c16) into master (63769d8) will increase coverage by 0.62%.
The diff coverage is 39.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   47.56%   48.19%   +0.62%     
==========================================
  Files          32       32              
  Lines        1337     1413      +76     
  Branches      148      152       +4     
==========================================
+ Hits          636      681      +45     
- Misses        693      724      +31     
  Partials        8        8              
Impacted Files Coverage Δ
htcanalyze/log_analyzer/condor_log/ram_history.py 27.58% <0.00%> (ø)
...nalyze/log_analyzer/event_handler/event_handler.py 30.87% <28.57%> (+4.32%) ⬆️
htcanalyze/log_analyzer/event_handler/states.py 63.75% <50.00%> (+4.32%) ⬆️
...tcanalyze/log_analyzer/event_handler/job_events.py 57.47% <57.14%> (+4.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63769d8...e034c16. Read the comment docs.

@mathisloevenich mathisloevenich merged commit abbb232 into master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants