Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declutter by removing duplicate link in the same footer section #81

Closed
Ainali opened this issue Feb 9, 2022 · 2 comments · Fixed by #85
Closed

Declutter by removing duplicate link in the same footer section #81

Ainali opened this issue Feb 9, 2022 · 2 comments · Fixed by #85

Comments

@Ainali
Copy link
Member

Ainali commented Feb 9, 2022

As identified in publiccodenet/about#1105 in the footer.liquid we generate a link to the repository twice in the "GitHub repository information" section. I suggest we remove <li><a href="{{ site.github.repository_url }}">Content and code</a></li> and just have the link that is explained with a sentence left (<a href="{{ site.github.repository_url }}">{{ site.github.repository_nwo }}</a>).

@ElenaFdR
Copy link
Member

As mentioned in #55, @angelplasma and I had planned to get rid of footer.liquid everywhere; we've already done this on pubbliccode.net. Since it doesn't seem like that's broken anything, I propose we get rid of it everywhere now.

@ElenaFdR
Copy link
Member

I still propose we get rid of all 3 bullets, as experienced users will navigate via the universal nav or footer and novice users will be invited by the 'edit this page' buttons in the right nav.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants