treewide: Remove Banshee

Author: colluca

.github/workflows/ci.yml

@@ -128,34 +128,6 @@ jobs:
         run: |
           make SIM_DIR=./runs/simple annotate -j
 
-  # #########################################
-  # # Build SW on Snitch Cluster w/ Banshee #
-  # #########################################
-
-  # sw-snitch-cluster-banshee:
-  #   name: Simulate SW on Snitch Cluster w/ Banshee
-  #   runs-on: ubuntu-22.04
-  #   needs: build-docker
-  #   if: >
-  #     github.event_name != 'pull_request' ||
-  #     github.event.pull_request.head.repo.full_name != github.repository
-  #   container:
-  #     image: ghcr.io/pulp-platform/snitch_cluster:${{ github.ref_name }}
-  #   steps:
-  #     - uses: actions/checkout@v2
-  #       with:
-  #         submodules: 'recursive'
-  #     - name: Build Software
-  #       run: |
-  #         bender vendor init
-  #         make -C target/snitch_cluster SELECT_RUNTIME=banshee sw
-  #     - name: Run Tests
-  #       env:
-  #         SNITCH_LOG: info
-  #       working-directory: target/snitch_cluster
-  #       run: |
-  #         ./util/run.py sw/run.yaml --simulator banshee -j
-
   ######################
   # Sources Up-to-Date #
   ######################

.gitlab-ci.yml

@@ -72,16 +72,6 @@ snitch-cluster-sw:
       - target/snitch_cluster/sw/**/build/*.elf
     expire_in: 1 day
 
-snitch-cluster-sw-banshee:
-  needs: [setup]
-  script:
-    - cd target/snitch_cluster
-    - make SELECT_RUNTIME=banshee sw
-  artifacts:
-    paths:
-      - target/snitch_cluster/sw/**/build/*.elf
-    expire_in: 1 day
-
 #######################
 # Standalone IP tests #
 #######################
@@ -140,22 +130,6 @@ snitch-cluster-vsim:
     - cd sw/apps/blas/gemm/test && ./test.sh && cd -
     - cd sw/apps/dnn/transpose/test && ./test.sh && cd -
 
-# Banshee
-snitch-cluster-banshee:
-  needs: [setup, snitch-cluster-sw-banshee]
-  variables:
-    SNITCH_LOG: info
-  script:
-    - rustup install 1.63.0
-    - rustup override set 1.63.0
-    - rustc --version
-    - rustup --version
-    - git clone git@github.com:pulp-platform/banshee.git --recurse-submodules
-    - cd banshee
-    - cargo install --debug --path .
-    - cd ../target/snitch_cluster
-    - ./util/run.py sw/run.yaml --simulator banshee -j --run-dir runs/banshee
-
 # Tests requiring hardware FDIV unit
 snitch-cluster-fdiv-vsim:
   needs: [setup]

README.md

@@ -16,7 +16,7 @@ What can you expect to find in this repository?
 - The RISC-V [Snitch integer core](https://pulp-platform.github.io/snitch_cluster/rm/snitch.html). This can be useful stand-alone if you are just interested in re-using the core for your project, e.g., as a tiny control core or you want to make a peripheral smart. The sky is the limit.
 - The [Snitch cluster](https://pulp-platform.github.io/snitch_cluster/rm/snitch_cluster.html). A highly configurable cluster containing one to many integer cores with optional floating-point capabilities as well as our custom ISA extensions `Xssr`, `Xfrep`, and `Xdma`.
 - A runtime and example applications for the Snitch cluster.
-- RTL simulation environments for Verilator, Questa Advanced Simulator, and VCS, as well as configurations for our [Banshee system simulator](https://github.com/pulp-platform/banshee)
+- RTL simulation environments for Verilator, Questa Advanced Simulator, and VCS, as well as configurations for the [GVSoC system simulator](https://github.com/gvsoc/gvsoc)
 
 This code was previously hosted in the [Snitch monorepo](https://github.com/pulp-platform/snitch) and was spun off into its own repository to simplify maintenance and dependency handling. Note that our Snitch-based manycore system [Occamy](https://github.com/pulp-platform/occamy) has also moved.
 

docs/ug/tutorial.md

@@ -45,11 +45,6 @@ These commands compile the RTL sources respectively in `work-vlt`, `work-vsim` a
 !!! info
     The variable `DEBUG=ON` is required when using QuestaSim to preserve the visibility of all internal signals. If you need to inspect the simulation waveforms, you should set this variable when building the simulation model. For faster simulations you can omit the variable assignment, allowing QuestaSim to optimize internal signals away.
 
-
-## Building the Banshee simulator
-
-Instead of building a simulation model from the RTL sources, you can use our instruction-accurate simulator called `banshee`. To install the simulator, please follow the instructions provided in the [Banshee repository](https://github.com/pulp-platform/banshee).
-
 ## Configuring the hardware
 
 The Snitch cluster RTL sources are partly automatically generated from a configuration file provided in `.hjson` format. Several RTL files are templated and use the `.hjson` configuration file as input to fill in the template. An example is [snitch_cluster_wrapper.sv.tpl](https://github.com/pulp-platform/{{ repo }}/blob/{{ branch }}/hw/snitch_cluster/src/snitch_cluster_wrapper.sv.tpl).
@@ -69,20 +64,14 @@ If you want to use a custom configuration, just point `CFG_OVERRIDE` to the path
 
 ## Building the software
 
-To build all of the software for the Snitch cluster, run the following command. Different simulators may require different C runtime or library function implementations, so different options have to be specified to select the appropriate implementation, e.g. for Banshee simulations or OpenOCD semi-hosting:
+To build all of the software for the Snitch cluster, run the following command. Different simulators may require different C runtime or library function implementations, so different options have to be specified to select the appropriate implementation, e.g. for OpenOCD semi-hosting:
 
 === "RTL"
 
     ```bash
     make DEBUG=ON sw -j
     ```
 
-=== "Banshee"
-
-    ```bash
-    make DEBUG=ON SELECT_RUNTIME=banshee sw -j
-    ```
-
 === "OpenOCD"
 
     ```bash
@@ -130,12 +119,6 @@ Run one of the executables which was compiled in the previous step on your Snitc
     bin/snitch_cluster.vcs sw/apps/blas/axpy/build/axpy.elf
     ```
 
-=== "Banshee"
-
-    ```shell
-    banshee --no-opt-llvm --no-opt-jit --configuration src/banshee.yaml --trace sw/apps/blas/axpy/build/axpy.elf
-    ```
-
 The simulator binaries can be invoked from any directory, just adapt the relative paths in the preceding commands accordingly, or use absolute paths. We refer to the working directory where the simulation is launched as the _simulation directory_. Within it, you will find several log files produced by the RTL simulation.
 
 !!! tip

target/README.md

@@ -6,11 +6,9 @@ This subdirectory contains the supported systems and their simulation environmen
   - `snitch_cluster`
     - `cfg`: containing the configuration files `*.hsjon`.
     - `generated`: contains the generated `bootdata.cc` and RTL wrapper for the snitch cluster `snitch_cluster_wrapper.sv`.
-    - `src`: contains the [Banshee](https://github.com/pulp-platform/banshee) configuration for the snitch cluster.
     - `sw`: contains all shared
       - `apps`: contains applications for the snitch cluster.
       - `runtime`: contains the HW specific runtime implementation for the snitch cluster.
         - `rtl`: RTL-related startup implmentations.
-        - `banshee`: Banshee-related startup SW implmentations.
       - `tests`: lists of tests that can run on the snitch cluster.
     - `test`: contains testharness and bootrom of the snitch cluster

target/snitch_cluster/Makefile

@@ -13,8 +13,6 @@
 DEBUG ?= OFF
 # Override default config file
 CFG_OVERRIDE ?=
-# Select snRuntime implementation: "banshee" or "rtl" (default)
-SELECT_RUNTIME ?= rtl
 
 .DEFAULT_GOAL := help
 .PHONY: all clean

target/snitch_cluster/src/banshee.yaml

@@ -15,9 +15,6 @@ $(APP)_INCDIRS += $(ROOT)/sw/deps/riscv-opcodes
 
 $(APP)_RISCV_CFLAGS += $(RISCV_CFLAGS)
 $(APP)_RISCV_CFLAGS += $(addprefix -I,$($(APP)_INCDIRS))
-ifeq ($(SELECT_RUNTIME), banshee)
-$(APP)_RISCV_CFLAGS += -DBIST
-endif
 
 $(APP)_LIBS += $(SNRT_TARGET_DIR)/build/libsnRuntime.a
 

target/snitch_cluster/sw/apps/common.mk

@@ -4,70 +4,50 @@
 
 runs:
   - elf: tests/build/alias.elf
-    simulators: [vsim, vcs, verilator] # banshee does not model alias regions
+    simulators: [vsim, vcs, verilator]
   - elf: tests/build/atomics.elf
-    simulators: [vsim, vcs, verilator, gvsoc] # banshee fails with exit code 0x4
   - elf: tests/build/barrier.elf
   - elf: tests/build/data_mover.elf
-    simulators: [vsim, vcs, verilator, banshee]
+    simulators: [vsim, vcs, verilator]
   - elf: tests/build/dma_empty_transfer.elf
   - elf: tests/build/dma_simple.elf
   - elf: tests/build/event_unit.elf
-    simulators: [vsim, vcs, verilator, banshee]
+    simulators: [vsim, vcs, verilator]
   - elf: tests/build/fence_i.elf
   - elf: tests/build/fp8_comparison_scalar.elf
-    simulators: [vsim, vcs, verilator, gvsoc] # banshee fails with segfault
   - elf: tests/build/fp8_comparison_vector.elf
-    simulators: [vsim, vcs, verilator, gvsoc] # banshee fails with segfault
   - elf: tests/build/fp8_computation_scalar.elf
-    simulators: [vsim, vcs, verilator, gvsoc] # banshee fails with JIT issue
   - elf: tests/build/fp8_computation_vector.elf
-    simulators: [vsim, vcs, verilator, gvsoc] # banshee fails with exit code 0x6
   - elf: tests/build/fp8alt_comparison_scalar.elf
-    simulators: [vsim, vcs, verilator, gvsoc] # banshee fails with segfault
   - elf: tests/build/fp8alt_comparison_vector.elf
-    simulators: [vsim, vcs, verilator, gvsoc] # banshee fails with exit code 0x10
   - elf: tests/build/fp8alt_computation_scalar.elf
-    simulators: [vsim, vcs, verilator, gvsoc] # banshee fails with JIT issue
   - elf: tests/build/fp8alt_computation_vector.elf
-    simulators: [vsim, vcs, verilator, gvsoc] # banshee fails with exit code 0x12
   - elf: tests/build/fp16_comparison_scalar.elf
-    simulators: [vsim, vcs, verilator, gvsoc] # banshee fails with exit code 0x10
   - elf: tests/build/fp16_comparison_vector.elf
-    simulators: [vsim, vcs, verilator, gvsoc] # banshee fails with exit code 0x10
   - elf: tests/build/fp16_computation_scalar.elf
-    simulators: [vsim, vcs, verilator, gvsoc] # banshee fails with JIT issue
   - elf: tests/build/fp16_computation_vector.elf
-    simulators: [vsim, vcs, verilator, gvsoc] # banshee fails with exit code 0x6
   - elf: tests/build/fp16alt_comparison_scalar.elf
-    simulators: [vsim, vcs, verilator, gvsoc] # banshee fails with exit code 0x10
   - elf: tests/build/fp16alt_comparison_vector.elf
-    simulators: [vsim, vcs, verilator, gvsoc] # banshee fails with exit code 0x10
   - elf: tests/build/fp16alt_computation_scalar.elf
-    simulators: [vsim, vcs, verilator, gvsoc] # banshee fails with JIT issue
   - elf: tests/build/fp16alt_computation_vector.elf
-    simulators: [vsim, vcs, verilator, gvsoc] # banshee fails with exit code 0x16
   - elf: tests/build/fp32_comparison_scalar.elf
   - elf: tests/build/fp32_comparison_vector.elf
   - elf: tests/build/fp32_computation_scalar.elf
-    simulators: [vsim, vcs, verilator, gvsoc] # banshee fails with exit code 0x2
   - elf: tests/build/fp32_computation_vector.elf
-    simulators: [vsim, vcs, verilator, gvsoc] # banshee fails with exit code 0x2
   - elf: tests/build/fp32_conversions_scalar.elf
-    simulators: [vsim, vcs, verilator, gvsoc] # banshee fails with illegal instruction
   # - elf: tests/build/fp64_conversions_scalar.elf
   #   simulators: [vsim, vcs, verilator]
   - elf: tests/build/interrupt_local.elf
-    simulators: [vsim, vcs, verilator, banshee]
+    simulators: [vsim, vcs, verilator]
   - elf: tests/build/multi_cluster.elf
   - elf: tests/build/openmp_parallel.elf
-    simulators: [vsim, vcs, verilator, banshee]
+    simulators: [vsim, vcs, verilator]
   - elf: tests/build/openmp_for_static_schedule.elf
-    simulators: [vsim, vcs, verilator, banshee]
+    simulators: [vsim, vcs, verilator]
   - elf: tests/build/openmp_double_buffering.elf
-    simulators: [vsim, vcs, verilator, banshee]
+    simulators: [vsim, vcs, verilator]
   - elf: tests/build/perf_cnt.elf
-    simulators: [vsim, vcs, verilator] # banshee does not have HW performance counters
+    simulators: [vsim, vcs, verilator]
   - elf: tests/build/printf_simple.elf
   - elf: tests/build/printf_fmtint.elf
   - elf: tests/build/simple.elf
@@ -78,9 +58,9 @@ runs:
   - elf: tests/build/non_null_exitcode.elf
     retcode: 56
   - elf: tests/build/caq.elf
-    simulators: [vsim, vcs, verilator, banshee] # GVSOC does not model caq
+    simulators: [vsim, vcs, verilator] # GVSOC does not model caq
   - elf: tests/build/caq_frep.elf
-    simulators: [vsim, vcs, verilator] # banshee does not model FREP timing
+    simulators: [vsim, vcs, verilator]
   - elf: apps/blas/axpy/build/axpy.elf
     cmd: [../../../sw/blas/axpy/scripts/verify.py, "${sim_bin}", "${elf}"]
   - elf: apps/blas/gemm/build/gemm.elf
@@ -100,13 +80,13 @@ runs:
   - elf: apps/dnn/fused_concat_linear/build/fused_concat_linear.elf
     cmd: [../../../sw/dnn/fused_concat_linear/scripts/verify.py, "${sim_bin}", "${elf}"]
   - elf: apps/dnn/transpose/build/transpose.elf
-    simulators: [vsim, vcs, verilator, banshee]
+    simulators: [vsim, vcs, verilator]
     cmd: [../../../sw/dnn/transpose/scripts/verify.py, "${sim_bin}", "${elf}"]
   - elf: apps/montecarlo/pi_estimation/build/pi_estimation.elf
   - elf: apps/atax/build/atax.elf
     cmd: [../../../sw/apps/atax/scripts/verify.py, "${sim_bin}", "${elf}"]
   - elf: apps/covariance/build/covariance.elf
-    simulators: [vsim, vcs, verilator, banshee]
+    simulators: [vsim, vcs, verilator]
     cmd: [../../../sw/apps/covariance/scripts/verify.py, "${sim_bin}", "${elf}"]
   - elf: apps/doitgen/build/doitgen.elf
     cmd: [../../../sw/apps/doitgen/scripts/verify.py, "${sim_bin}", "${elf}"]