treewide: Apply minor review changes

Author: colluca

Bender.local

@@ -74,7 +74,7 @@ packages:
     revision: c396bbf477457b184a74b7f2386302f5895bb522
     version: null
     source:
-      Git: git@github.com:pulp-platform/iDMA.git
+      Git: https://github.com/pulp-platform/iDMA.git
     dependencies:
     - axi
     - axi_stream
@@ -83,8 +83,8 @@ packages:
     - obi
     - register_interface
   obi:
-    revision: 0155fc34e900c7c884e081c0a1114a247937ff69
-    version: 0.1.7
+    revision: 8097928cf1b43712f93d5356f336397879b4ad2c
+    version: 0.1.6
     source:
       Git: https://github.com/pulp-platform/obi.git
     dependencies:

Bender.lock

@@ -27,7 +27,7 @@ dependencies:
   tech_cells_generic: { git: https://github.com/pulp-platform/tech_cells_generic, version:  0.2.13      }
   riscv-dbg:          { git: https://github.com/pulp-platform/riscv-dbg,          version:  0.8.0       }
   cluster_icache:     { git: https://github.com/pulp-platform/cluster_icache.git, rev: 64e21ae455bbdde850c4df13bef86ea55ac42537 }
-  idma:               { git: git@github.com:pulp-platform/iDMA.git,               rev: __deploy__3c6bbb7__multicast-integration }
+  idma:               { git: https://github.com/pulp-platform/iDMA.git,           rev: __deploy__3c6bbb7__multicast-integration }
 
 export_include_dirs:
   - hw/reqrsp_interface/include

Bender.yml

@@ -248,6 +248,8 @@ module snitch import snitch_pkg::*; import riscv_instr::*; #(
   logic csr_en;
   logic csr_dump;
   logic csr_stall_d, csr_stall_q;
+  // Multicast mask
+  logic [31:0] csr_mcast_d, csr_mcast_q;
 
   localparam logic M = 0;
   localparam logic S = 1;
@@ -281,10 +283,7 @@ module snitch import snitch_pkg::*; import riscv_instr::*; #(
   dm::dcsr_t dcsr_d, dcsr_q;
   logic [31:0] dpc_d, dpc_q;
   logic [31:0] dscratch_d, dscratch_q;
-
   logic debug_d, debug_q;
-  // Multicast mask
-  logic [31:0] csr_mcast_d, csr_mcast_q;
 
   `FFAR(scratch_q, scratch_d, '0, clk_i, rst_i)
   `FFAR(tvec_q, tvec_d, '0, clk_i, rst_i)
@@ -2357,9 +2356,9 @@ module snitch import snitch_pkg::*; import riscv_instr::*; #(
     dcsr_d = dcsr_q;
     dpc_d = dpc_q;
     dscratch_d = dscratch_q;
-    csr_mcast_d = csr_mcast_q;
 
     csr_stall_d = csr_stall_q;
+    csr_mcast_d = csr_mcast_q;
 
     if (barrier_i) csr_stall_d = 1'b0;
     barrier_o = 1'b0;

hw/snitch/src/snitch.sv

@@ -99,11 +99,6 @@ inline uint32_t snrt_dma_start_1d_mcast_wideptr(uint64_t dst, uint64_t src,
                                      10, OP_CUSTOM1)),
                    "r"(reg_size));
 
-    // Reset dmmcast or next transfers will inherit this setting
-    asm volatile(".word %0\n" ::"i"(R_TYPE_ENCODE(DMMCAST_FUNCT7, 0b00000, 0,
-                                                  XDMA_FUNCT3, 0, OP_CUSTOM1)),
-                 "r"(reg_mcast));
-
     return reg_txid;
 }
 

sw/snRuntime/src/dma.h

@@ -81,7 +81,7 @@ inline void snrt_wake_all(uint32_t core_mask) {
     // Note: we need to address another cluster's address space
     //       because the cluster XBAR has not been extended to support
     //       multicast yet. We address the second cluster, if we are the
-    //       first cluster, and the second otherwise.
+    //       first cluster, and the first cluster otherwise.
     uintptr_t addr = (uintptr_t)snrt_cluster_clint_set_ptr() -
                      SNRT_CLUSTER_OFFSET * snrt_cluster_idx();
     if (snrt_cluster_idx() == 0) addr += SNRT_CLUSTER_OFFSET;

sw/snRuntime/src/sync.h

@@ -160,7 +160,7 @@
                 },  
                 "enable_multicast": {
                     "type": "boolean",
-                    "description": "Whether to enable the mutlicast feature into the cluster",
+                    "description": "Whether to enable multicast in the cluster.",
                     "default": false
                 },
                 "hart_base_id": {