Skip to content

sw: Fix warning in kmp.c #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zero9178
Copy link
Contributor

@zero9178 zero9178 commented May 1, 2024

Compiling the file would previously emit

warning: missing terminating '"' character [-Winvalid-pp-token]

due to what I assume is a mistake introduced through some auto formatter. Multi line strings are actually illegal in C and Clang and GCC are simply kind enough to only emit a warning. The C does however implicitly concatenate two string literals appearing next to each other producing the intended result.

Compiling the file would previously emit ```
warning: missing terminating '"' character [-Winvalid-pp-token]
```
due to what I assume is a mistake introduced through some auto formatter. Multi line strings are actually illegal in C and Clang and GCC are simply kind enough to only emit a warning. The C does however implicitly concatenate two string literals appearing next to each other producing the intended result.
Copy link
Contributor

@viv-eth viv-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution @zero9178

@colluca
Copy link
Collaborator

colluca commented May 7, 2024

Thanks for your contribution @zero9178!

I'm closing this PR in favour of #135 where I included your changes.

@colluca colluca closed this May 7, 2024
@zero9178 zero9178 deleted the fix-string-warnings branch May 11, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants