sw: Fix warnings in compilation #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiling the file would previously emit ``` warning: missing terminating '"' character [-Winvalid-pp-token] ``` due to what I assume is a mistake introduced through some auto formatter. Multi line strings are actually illegal in C and Clang and GCC are simply kind enough to only emit a warning. The C does however implicitly concatenate two string literals appearing next to each other producing the intended result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional fixes to #134.
Also definitively removes the custom math library, which was only required as a patch against the FP-int inconsistency, which has been fixed in #90.