Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit validation is outdated and fails on CI #96

Open
pedro-psb opened this issue Mar 8, 2024 · 0 comments
Open

Commit validation is outdated and fails on CI #96

pedro-psb opened this issue Mar 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@pedro-psb
Copy link
Member

I've received this error on a PR and the issue #94 is valid.

Checking commit message for 343cbb4.
Error: issue #94 has invalid status of CLOSED - CURRENTRELEASE. Status must be one of NEW, ASSIGNED, POST, MODIFIED.
Error: Process completed with exit code 1.

The problem is that the commit-validation script is outdated and points to a no longer used service:

def __check_status(issue):
response = requests.get(f"{REDMINE_URL}/issues/{issue}.json")
response.raise_for_status()
bug_json = response.json()
status = bug_json["issue"]["status"]["name"]
if status not in STATUSES:
sys.exit(
"Error: issue #{issue} has invalid status of {status}. Status must be one of "
"{statuses}.".format(issue=issue, status=status, statuses=", ".join(STATUSES))
)

@pedro-psb pedro-psb added the bug Something isn't working label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant