Skip to content

Add libsecret-1-0 to Linux install #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025

Conversation

Spiker985
Copy link
Member

Ubuntu-latest (ubuntu-24.04 as of now) doesn't include libsecret as part of its installed packages

Per the Ubuntu 22.04 runner doc, it had libsecret-1-dev, however, I can't find a good reason to use libsecret-1-dev instead of libsecret-1-0

@Spiker985
Copy link
Member Author

Spiker985 commented Apr 30, 2025

Per the CI, removing the libsecret install does cause the linux test to fail - as was my personal experience

So this should be a-okay to merge

@Spiker985 Spiker985 added the bug Something isn't working label Apr 30, 2025
@Spiker985 Spiker985 self-assigned this Apr 30, 2025
@savetheclocktower savetheclocktower merged commit 08e7d34 into main Apr 30, 2025
6 checks passed
@savetheclocktower savetheclocktower deleted the S985-Support-Ubuntu-Latest branch April 30, 2025 06:17
@Spiker985 Spiker985 requested a review from confused-Techie May 1, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants