Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

o-column-{x} should be o-column--{x} #46

Open
stuartromanek opened this issue Apr 2, 2018 · 3 comments
Open

o-column-{x} should be o-column--{x} #46

stuartromanek opened this issue Apr 2, 2018 · 3 comments

Comments

@stuartromanek
Copy link

@austinstarin I'm sure this was by design but is there a strong argument for why these don't follow the modifier pattern?

@austinstarin
Copy link
Contributor

@bgantick and I were just talking about this... I think we were thinking that there wasn't a o-column to modify.

@stuartromanek
Copy link
Author

But there could be. And what the generated prop is doing is very modifier'y

@austinstarin
Copy link
Contributor

That's true. Do you want to get consensus and make a PR?

I don't have strong feelings.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants