Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Grid gutter creation needs a mixin/map #9

Closed
austinstarin opened this issue Oct 5, 2017 · 5 comments
Closed

Grid gutter creation needs a mixin/map #9

austinstarin opened this issue Oct 5, 2017 · 5 comments

Comments

@austinstarin
Copy link
Contributor

No description provided.

@abea
Copy link

abea commented Oct 5, 2017

I think we need to be more granular than we are currently. As an example, in a 12 column grid, an 8 column element makes sense to be 100% at "medium" and "small" breakpoints. A 2 column element, on the other hand, probably should not be 100% width at "medium" and maybe shouldn't be wider than 50% ever.

TLDR; The system seems a bit crude at the moment by treating treating all column classes the same.

@austinstarin
Copy link
Contributor Author

Yes, see #12

The hope is to create selectors to handle different break scenarios.

@austinstarin
Copy link
Contributor Author

This ticket is in RE to creating something like https://github.com/punkave/dfmch/blob/develop/src/sass/objects/_grid.scss#L11-L19

@abea
Copy link

abea commented Oct 5, 2017

Sorry, I'll move the comment. I actually started there, but wasn't sure that was the right one...

@austinstarin
Copy link
Contributor Author

No worries! Sorry for opening issues and not explaining them thoroughly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants