(PA-7091) Add support for Ruby 3.2 and 3.3 #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhashizume
reviewed
Jan 17, 2025
beaker-puppet.gemspec
Outdated
| @@ -11,7 +11,7 @@ Gem::Specification.new do |s| | |||
| s.description = 'For use for the Beaker acceptance testing tool' | |||
| s.license = 'Apache-2.0' | |||
|
|
|||
| s.required_ruby_version = '>= 2.7', '< 3.2' | |||
| s.required_ruby_version = '>= 2.7', '< 3.3' | |||
There was a problem hiding this comment.
What are the issues with using Ruby >= 3.3? Is it just that we're not testing against those versions?
There was a problem hiding this comment.
ah yeah good point, I didn't think to add that. Updated.
Ruby 3.2 introduced two breaking changes: * String#taint was removed entirely * Fixnum was removed in favor of Integer Updates the gemspec to allow 3.2 - 3.3 Update workflow to test on the new versions
mhashizume
approved these changes
Jan 17, 2025
Closed
joshcooper
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
inifilegem has not been updated in 10+ years and does not run on Ruby 3.2 because it relies on String#taint. There is a o-inifile gem, but it has the sametaintproblem.So vendor the MIT licensed
inifilecode into beaker-puppet and update it for Ruby 3.2. According to https://fossa.com/blog/open-source-licenses-101-mit-license/ in order to copy and/or modify the code we need to:I've included both of those in
inifile.rbrubocop is failing because of an incompatibility with
rubocop-factory_botandrubocop-rspec_rails, see puppetlabs/dependency_checker#72 (comment) for an example. That issue is fixed in #263