Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PA-6897) Get rubocop working again #263

Merged
merged 2 commits into from
Jan 17, 2025
Merged

(PA-6897) Get rubocop working again #263

merged 2 commits into from
Jan 17, 2025

Conversation

joshcooper
Copy link
Contributor

@joshcooper joshcooper commented Jan 17, 2025

Fixes the following error and regenerates .rubocop_todo.yml

$ bundle exec rake rubocop
Error: Property AutoCorrect of cop FactoryBot/CreateList is supposed to be a boolean and contextual is not.

@joshcooper joshcooper changed the title Rubocop (PA-6897) Get rubocop working again Jan 17, 2025
@joshcooper joshcooper marked this pull request as ready for review January 17, 2025 01:31
@joshcooper joshcooper requested a review from a team as a code owner January 17, 2025 01:31
Earlier versions of voxpupuli-rubocop resolve to rubocop-factory_bot 2.26.0 that
causes this error:

```
$ bundle exec rubocop
Error: Property AutoCorrect of cop FactoryBot/CreateList is supposed to be a boolean and contextual is not
```

See rubocop/rubocop-rspec#1916

Update to newer voxpupuli-rubocop to avoid this issue.
bundle exec rubocop --auto-gen-config
@mhashizume mhashizume merged commit b992bf0 into main Jan 17, 2025
8 checks passed
@mhashizume mhashizume deleted the rubocop branch January 17, 2025 18:15
@joshcooper joshcooper added the bug label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants