Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-2120) Update sources with bookworm-backports repo #95

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

skyamgarp
Copy link
Contributor

@skyamgarp skyamgarp commented Oct 28, 2024

Summary

This PR is to fix the error introduced when added support for Debian-12.
Ref: https://github.com/puppetlabs/puppetlabs-apache/actions/runs/11460926405/job/31945092498

Additional Context

This PR is to add bookworm-backports to sources so the package libapache2-mod-apreq2 is available to install while running the tests.

@skyamgarp
Copy link
Contributor Author

skyamgarp commented Oct 30, 2024

@puppetlabs/devx ,
With this PR I am able to build the image but the changes I expect to sources are not getting executed. I observe the if condition doesn't pass. But when I try the same if block on built image it works. Can someone pls review and let me know if I am missing anything here?
Thanks.

@skyamgarp skyamgarp force-pushed the CAT-2120 branch 2 times, most recently from 01909db to 70e1c78 Compare October 30, 2024 17:53
@jordanbreen28 jordanbreen28 marked this pull request as ready for review October 31, 2024 10:24
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner October 31, 2024 10:24
(CAT-2120) Updated Code

(CAT-2120) Updates ENV variables

(CAT-2120) Update condition for debian

(CAT-2120) Updated if statement

(CAT-2120) Update timeout minutes

(CAT-2120) Updated timeout minutes
@jordanbreen28 jordanbreen28 merged commit c27902f into main Nov 12, 2024
10 checks passed
@jordanbreen28 jordanbreen28 deleted the CAT-2120 branch November 12, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants