Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --top-scope-variables cli argument, fix #228 #229

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

jcharaoui
Copy link

Summary

This adds the --top-scope-variables CLI option that sets PuppetLint.configuration.top_scope_variables.

Related Issues (if any)

#228

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@jcharaoui jcharaoui requested review from bastelfreak and a team as code owners January 23, 2025 23:38
@jcharaoui jcharaoui force-pushed the top_scope_facts_cli branch from da71597 to f4a94d3 Compare January 30, 2025 13:22
@jcharaoui
Copy link
Author

Removed an extra blank line.

@jcharaoui
Copy link
Author

Not sure how to deal with this issue, though:

spec (ruby 3.3) / spec: lib/puppet-lint/optparser.rb#L20
Metrics/MethodLength: Method has too many lines. [111/108]

@LukasAud
Copy link

Not sure how to deal with this issue, though:

spec (ruby 3.3) / spec: lib/puppet-lint/optparser.rb#L20
Metrics/MethodLength: Method has too many lines. [111/108]

Manually adjusting the Metrics/MethodLength variable in the rubocop_todo.yml file should do the trick. Alternatively, you can run bundle exec rubocop --auto-gen-config to have Rubocop regenerate the file with the new exception.

@jcharaoui
Copy link
Author

I fixed the comment and regenerated the Rubocop config for the line length issue.

@jcharaoui
Copy link
Author

Fixed the explicit namespace failure. Specs should now pass. Sorry for the churn here.

Copy link

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 91b1886 into puppetlabs:main Feb 19, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants