Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/gh 624 syntax error #634

Closed
wants to merge 2 commits into from

Conversation

hesco
Copy link

@hesco hesco commented Apr 10, 2024

Summary

Catch a certain syntax error, recommend an upgrade to client side puppet version => ^7
New documentation in README.md, CHANGELOG.md, and
syntax error exception caught in lib/puppet/provider/vcsrepo/cvs.rb
Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)

Using puppet6 on the client machine, elicits the syntax error documented at:
#624

  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@hesco hesco requested review from bastelfreak, smortex and a team as code owners April 10, 2024 22:22
@CLAassistant
Copy link

CLAassistant commented Apr 10, 2024

CLA assistant check
All committers have signed the CLA.

@hesco hesco force-pushed the enhancement/gh_624--syntax_error branch from dc5b93f to e05b69a Compare April 10, 2024 22:24
@smortex
Copy link
Collaborator

smortex commented Apr 10, 2024

#601 dropped support for Puppet 6, and was followed with a major version bump with appropriate ChangeLog entry:

## [v6.0.0](https://github.com/puppetlabs/puppetlabs-vcsrepo/tree/v6.0.0) - 2023-04-19
[Full Changelog](https://github.com/puppetlabs/puppetlabs-vcsrepo/compare/v5.5.0...v6.0.0)
### Changed
- (CONT-803) Add Support for Puppet 8 / Drop Support for Puppet 6 [#601](https://github.com/puppetlabs/puppetlabs-vcsrepo/pull/601) ([david22swan](https://github.com/david22swan))

We also include metadata that indicate what version of Puppet a module version require:

"requirements": [
{
"name": "puppet",
"version_requirement": ">= 7.0.0 < 9.0.0"
}
],

For these reasons, I am not in favor of adding extra code to give hints for such known bad configurations.

@hesco
Copy link
Author

hesco commented Apr 11, 2024

I had rather hoped that r10k puppetfile install would have made a lot of noise about installing a version unsupported this fundamentally in its environment.

#601 dropped support for Puppet 6, and was followed with a major version bump with appropriate ChangeLog entry:

## [v6.0.0](https://github.com/puppetlabs/puppetlabs-vcsrepo/tree/v6.0.0) - 2023-04-19
[Full Changelog](https://github.com/puppetlabs/puppetlabs-vcsrepo/compare/v5.5.0...v6.0.0)
### Changed
- (CONT-803) Add Support for Puppet 8 / Drop Support for Puppet 6 [#601](https://github.com/puppetlabs/puppetlabs-vcsrepo/pull/601) ([david22swan](https://github.com/david22swan))

We also include metadata that indicate what version of Puppet a module version require:

"requirements": [
{
"name": "puppet",
"version_requirement": ">= 7.0.0 < 9.0.0"
}
],

For these reasons, I am not in favor of adding extra code to give hints for such known bad configurations.

understood. Thank you for your consideration.

@hesco hesco closed this Apr 11, 2024
@hesco hesco deleted the enhancement/gh_624--syntax_error branch May 13, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants