Skip to content

Commit

Permalink
Merge pull request #159 from pusher/remove-old-pn-client
Browse files Browse the repository at this point in the history
Drop NotificationClient
  • Loading branch information
mdpye authored Apr 1, 2020
2 parents 97cfe22 + bab7840 commit dc88172
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 166 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
### next
### next (major)

* [ADDED] option `encryption_master_key_base64`
* [DEPRECATED] option `encryption_master_key`

* [REMOVED] old support for Push Notifications, see https://github.com/pusher/push-notifications-python

### 2.1.4 2019-08-09

* [FIXED] TypeError in AuthenticationClient when using encrypted channels
Expand Down
81 changes: 0 additions & 81 deletions pusher/notification_client.py

This file was deleted.

22 changes: 0 additions & 22 deletions pusher/pusher.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
doc_string)

from pusher.pusher_client import PusherClient
from pusher.notification_client import NotificationClient
from pusher.authentication_client import AuthenticationClient


Expand Down Expand Up @@ -60,8 +59,6 @@ def __init__(
json_encoder=None,
json_decoder=None,
backend=None,
notification_host=None,
notification_ssl=True,
**backend_options):

self._pusher_client = PusherClient(
Expand Down Expand Up @@ -96,20 +93,6 @@ def __init__(
backend,
**backend_options)

self._notification_client = NotificationClient(
app_id,
key,
secret,
notification_ssl,
notification_host,
port,
timeout,
cluster,
json_encoder,
json_decoder,
backend,
**backend_options)


@classmethod
def from_url(cls, url, **options):
Expand Down Expand Up @@ -197,8 +180,3 @@ def authenticate(self, channel, socket_id, custom_data=None):
def validate_webhook(self, key, signature, body):
return self._authentication_client.validate_webhook(
key, signature, body)


@doc_string(NotificationClient.notify.__doc__)
def notify(self, interest, notification):
return self._notification_client.notify(interest, notification)
62 changes: 0 additions & 62 deletions pusher_tests/test_notification_client.py

This file was deleted.

0 comments on commit dc88172

Please sign in to comment.