Skip to content

Bug 870 translate dropdown data #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 13, 2025
Merged

Bug 870 translate dropdown data #879

merged 11 commits into from
May 13, 2025

Conversation

Miguel7373
Copy link
Collaborator

No description provided.

@Miguel7373 Miguel7373 force-pushed the bug/870-translate-dropdown-data branch from f1c1c46 to def1378 Compare April 29, 2025 12:30
ManuelMoeri
ManuelMoeri requested changes May 2, 2025
View reviewed changes
Copy link
Collaborator

@ManuelMoeri ManuelMoeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only did a quick review here.

@Miguel7373 Miguel7373 linked an issue May 5, 2025 that may be closed by this pull request
Translate dropdown data #870
Closed
RandomTannenbaum
RandomTannenbaum requested changes May 5, 2025
View reviewed changes
Copy link
Collaborator

@RandomTannenbaum RandomTannenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Keine" option in the person role level is not being translated yet.
The company dropdown options are not being translated yet.
Do we not want to translate the cities in the export dropdown?

@Miguel7373 Miguel7373 force-pushed the bug/870-translate-dropdown-data branch from bd375a1 to 51d9db3 Compare May 6, 2025 08:05
@Miguel7373 Miguel7373 force-pushed the bug/870-translate-dropdown-data branch from 49216ac to 678dc36 Compare May 6, 2025 08:22
@Miguel7373 Miguel7373 requested a review from Robin481 May 6, 2025 10:55
@Miguel7373 Miguel7373 marked this pull request as ready for review May 6, 2025 13:17
@Robin481 Robin481 assigned Miguel7373 and unassigned Robin481 May 8, 2025
@Miguel7373 Miguel7373 force-pushed the bug/870-translate-dropdown-data branch 2 times, most recently from 7af27b6 to 18c960d Compare May 8, 2025 13:20
@Miguel7373 Miguel7373 force-pushed the bug/870-translate-dropdown-data branch from 18c960d to 293e990 Compare May 8, 2025 13:29
@Miguel7373 Miguel7373 assigned Robin481 and unassigned Miguel7373 May 8, 2025
Robin481
Robin481 requested changes May 9, 2025
View reviewed changes
Copy link
Member

@Robin481 Robin481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I currently get a crash The asset "language-levels/keine.svg" is not present in the asset pipeline. stopping me from reviewing this further.

@Robin481 Robin481 assigned Miguel7373 and unassigned Robin481 May 9, 2025
@Miguel7373 Miguel7373 requested a review from Robin481 May 12, 2025 08:17
@Miguel7373 Miguel7373 assigned Robin481 and unassigned Miguel7373 May 12, 2025
@Robin481 Robin481 merged commit 9ef1c6d into master May 13, 2025
1 check passed
@Robin481 Robin481 deleted the bug/870-translate-dropdown-data branch May 13, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomTannenbaum RandomTannenbaum RandomTannenbaum requested changes

@ManuelMoeri ManuelMoeri ManuelMoeri requested changes

@Robin481 Robin481 Robin481 approved these changes

Assignees

@Robin481 Robin481

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate dropdown data
4 participants
@Miguel7373 @Robin481 @RandomTannenbaum @ManuelMoeri