Add categories and sub categories to skills to rate #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomTannenbaum
force-pushed
the
feature/883-displaying-of-default-skills
branch
from
476500d to
b27584a
Compare
RandomTannenbaum
requested changes
May 12, 2025
There was a problem hiding this comment.
I would not show categories that have no default skills:
Also maybe it would be good to change the background color of the default skill headers a bit, so when scrolling down they are easier distinguishable from the already rated skills??
The current logic seems to be very inefficient. You fetch all categories and skills per person and then also fetch categories per person etc. This produces way too many db queries. Take advantage of ActiveRecord functions like includes to eager load entries beforehand or try to use subqueries.
RandomTannenbaum
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.