Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Pydantic 2.x #26

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Upgrade to Pydantic 2.x #26

merged 2 commits into from
Feb 3, 2025

Conversation

akx
Copy link
Contributor

@akx akx commented Jan 31, 2025

Resolves that TODO about doing this.

Copy link
Contributor

@rambo rambo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a version bump, use bump2version I guess major since we change major dep version.

@akx
Copy link
Contributor Author

akx commented Feb 3, 2025

Needs a version bump, use bump2version I guess major since we change major dep version.

Done, though feels like this should be done in a release PR based on the changes since the last version (e.g. conventional-commits/semantic-release does this by way of an exclamation mark in the commit-type word).

@akx akx requested a review from rambo February 3, 2025 14:49
@rambo
Copy link
Contributor

rambo commented Feb 3, 2025

I agree that we should start using conventional commits but that requires everyone to make that effort. Perhaps next Hackathon should have a workshop on it and then we can add CI check that rejects commits that do not follow the rules to repos.

Copy link
Contributor

@rambo rambo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rambo rambo merged commit 0706aaa into pvarki:main Feb 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants