Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Refactor rm-ui to ensure best practices #21

Open
2 tasks
benjamsf opened this issue Mar 2, 2024 · 1 comment
Open
2 tasks

[Task] Refactor rm-ui to ensure best practices #21

benjamsf opened this issue Mar 2, 2024 · 1 comment
Labels
task:l Large task (approx 4h, max size of task)

Comments

@benjamsf
Copy link
Member

benjamsf commented Mar 2, 2024

Task

Refactor rm-ui to ensure best practices. There is some spaghetti in there.

Definition of Done

  •  Lookup and ticket/concept what should be done
  • Do the refactor
@benjamsf benjamsf added the task:l Large task (approx 4h, max size of task) label Mar 2, 2024
@benjamsf
Copy link
Member Author

Everything is mostly fine. One thing to get rid of is the dumbly-propped component UnfoldableCard, and make those few things to use UnfoldableCard2 & rename that to UnfoldableCard, instead.

Auth logic is fine, but it could use simplification/break it down better than it is broken down right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task:l Large task (approx 4h, max size of task)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benjamsf