[Bugfix 1.0] Quickfix getOperatingSystem, used to determine instructions in CreateMtlsView #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getOperatingSystem should be done in some other way as this is kind of fragile
|
The thing is kind of dumb rn. As of many androids state Linux Android as their user agent, so I need to figure out some other way to determine "Linux" if that is actually feasible anyway. However, due we don't really need linux flavor users right now (as wintak is the only desktop payload software), this would suffice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Rather temporarily fix a problem that appears to occur with various Android devices, with how /assets/helpers/getOperatingSystem is made to work. The implementation thinks some android flavour devices are "linux."
Also a little typo in QuickstartGuide wintak.
Why
As CreateMtlsView uses this helper to determine which instructions to show the user, this is rather irritating bug.
Changes
Remove the option of determining "a Linux" altogether and make the determination to fallback to Android if that is the case.
What next
Should make this logic not this fragile in the future & probably include CreateMtlsView a feature for the user to change the instruction type themselves.