Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Set dynamic asset loading to work build-time #31

Merged
merged 3 commits into from
Sep 7, 2024
Merged

Conversation

benjamsf
Copy link
Member

What does this PR do

Few fixes that weren't included in the previous feature PR:

  • Set dynamic asset loading to take place buildtime (otherwise, during production builds, asset setting won't run).
  • Fix privacypolicymodal not loading privacy policy from dynamic assets (forgot to set ns=dynamic)

Why

Didn't realize these until a production run of the integration repo was done

@benjamsf benjamsf self-assigned this Aug 14, 2024
@benjamsf
Copy link
Member Author

benjamsf commented Aug 14, 2024

Alright, review ready.

  • Set asset setting a build time job / tested this with a live production server
  • Fixed navbar logo size to be dynamic (as of the tower and pvatk logo are of different aspect ratio)
  • Just a few locale fixes: login will now be bit clearer like this:
Näyttökuva 2024-08-15 kello 1 52 46

Asking rambo for review, as of the significant change is about docker things.

@benjamsf benjamsf requested a review from rambo August 14, 2024 22:53
Copy link
Contributor

@rambo rambo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now that it's a build-time arg too (needed for the production builds)

@rambo rambo merged commit 2f2c329 into main Sep 7, 2024
4 checks passed
@rambo rambo deleted the rmui-qol-update-3 branch September 7, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants