[Feature] Add tacktracker zip download capability #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested |
From the wishing well
Instead navigate directly to the mtls cert download view
thejhh
approved these changes
Nov 16, 2024
| const handleChange = (e: React.ChangeEvent<HTMLInputElement>) => { | ||
| const upperCaseValue = e.target.value.toUpperCase(); | ||
| void formik.setFieldValue("code", upperCaseValue); | ||
| // Set shouldValidate to false to avoid returning a Promise | ||
| void setFieldValue("code", upperCaseValue, false); |
There was a problem hiding this comment.
Ignoring the promise. No async operation there so I think there's nothig that could fail here
| tracker: 2, // Tracker package | ||
| }; | ||
|
|
||
| const fileIndex = osToFileIndex[os]; |
There was a problem hiding this comment.
This could be using a helper function which uses a switch case for safer implementation.
Although since the input value comes from the pre-defined options it doesn't matter that much.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
UI changes for pvarki/docker-rasenmaeher-integration#115
Why
Need ability to choose TAKTracker zip, as for android taktracker wants this specific type of zipp
Depends on takrmapi change on this