Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature+Fix] KeyCloak access to RM admin + bugfix +deps update #46

Merged
merged 7 commits into from
Feb 12, 2025

Conversation

benjamsf
Copy link
Member

@benjamsf benjamsf commented Jan 25, 2025

What Does This PR Do

  • Add in KeyCloakUI access button to /app/admin/user-management. This is due as our version tag 1.6.0, we got Keycloak integrated.
  • At footer, check & show users deployment version, rather than RMAPI version
  • Fix few self-inflicted bugs with loginpage after the last merger
  • Dependency upgrade

Keycloak button

Add Keycloak button behind an unfoldable card at ManageUsersView, pics below.
addkc
Näyttökuva 2025-02-04 002024

  • This is really just useful for expert users at the moment
  • And for them to tell that Here It Is instead of having to guess where it is

Version

Earlier the footer used the rmapi api/v1/healthcheck call and showed the version value there to users. This confused users a bit. So we now show them the deployment version according to whatever is the RELEASE_TAG (eg. 1.6.0) at present deployment.

  • for this, we need to inject RELEASE_TAG env var to rmui's use at docker-compose.yml & for rmuidev at docker-compose-dev.yml.
  • I'll be adding those in an integration repo pointer update PR once we're there

Bugfixes

These regard to the lastly merged QoL feature of automatically go to Callisign view, if we come with login code link (

  • LoginView now awaits user manual input to the Formik form, instead of instantly polling whether a correct code was typed
  • EnrollmentView does not flicker in some cases when an admin approves an user's enrollment, and the user is redirected to CreateMtlsView

Upgrades

  • Upgrade deps
  • Vite seems to require defining allowed hosts, so define them (per SERVER_DOMAIN var from env, and 0.0.0.0 from docker network)

Now it does not look like deactivated if user navigates here not having a logincode
@benjamsf benjamsf added the feature Feature label Jan 25, 2025
@benjamsf benjamsf self-assigned this Jan 25, 2025
@benjamsf benjamsf changed the title [Feature+Fix] KeyCloak access to RM admin + bugfix [Feature+Fix] KeyCloak access to RM admin + bugfix +deps update Feb 3, 2025
@benjamsf benjamsf requested a review from thejhh February 3, 2025 22:41
Copy link

@Lonimokio Lonimokio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Clean and simple implementation.

@benjamsf benjamsf merged commit 48b8eda into main Feb 12, 2025
5 checks passed
@benjamsf benjamsf removed the request for review from thejhh February 12, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants