Skip to content

Update FCI.py for fixing isNoncollider #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Update FCI.py for fixing isNoncollider #179

merged 2 commits into from
Apr 16, 2024

Conversation

svenpieper
Copy link
Contributor

Editing isNoncollider() for FCI Algo

Fixing Bug:
If sep_sets does not contain certain node combination, it will led to a KeyError.

With this fix, None will automatically set by the get() func. Also get_node_map() will only called once to check set_sets for content, thus make it a bit more efficient.

Editing isNoncollider() for FCI Algo;
Fixing Bug:
If sep_set does not contain certain node combination, this will led to a KeyError. With this fix, None will automatically set by the get func. Also get_node_map() will only called once to check sep_set

Signed-off-by: Sven Pieper <101557437+svenpieper@users.noreply.github.com>
Signed-off-by: Sven Pieper <101557437+svenpieper@users.noreply.github.com>
Copy link
Collaborator

@kunwuz kunwuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fix!

@kunwuz kunwuz merged commit 5de8ee6 into py-why:main Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants