Skip to content

Minor issues fix #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 3, 2024
Merged

Minor issues fix #184

merged 4 commits into from
Jul 3, 2024

Conversation

EvieQ01
Copy link
Contributor

@EvieQ01 EvieQ01 commented Jul 2, 2024

No description provided.

kunwuz
kunwuz requested changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@kunwuz kunwuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fix. At the same time, it seems that there are some unrelated lines to be deleted (e.g., rules 8, 9, and 10). Please consider modifying it a bit.

@EvieQ01
Copy link
Contributor Author

EvieQ01 commented Jul 3, 2024

It is now fixed. Please kindly check again, thanks!

kunwuz
kunwuz approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@kunwuz kunwuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kunwuz kunwuz merged commit ae2f5b2 into py-why:main Jul 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunwuz kunwuz kunwuz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EvieQ01 @kunwuz