-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins #30
Draft
sezelt
wants to merge
17
commits into
py4dstem:dev
Choose a base branch
from
sezelt:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Plugins #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… calibration menu as plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to extend py4DGUI using a plugin mechanism. Classes living in the
py4d_browser_plugin
namespace and possessing certain attributes are automatically discovered and loaded. Currently the interface is minimal, and plugins have complete access to theDataViewer
object, but more over time the interface will become more strictly prescribed. As this develops, all non-core features (including ones currently available in the browser) will be implemented as plugins, and this should also help to clarify how to make an effective interface between the core and the plugins.To-dos:
The intention is that this will allow for greater flexibility when adding advanced analysis features as well as the ability to control acquisition hardware directly in the GUI. This also helps maintain a clean separation of state between the core functionality and any ancillary features.