PYTSK_SKIP_TZSET - Environment variable to skip default setting of timezone #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mezone to UTC that corrects libtsk behavior
|
Can you elaborate why do you want to do this? this leads to non-deterministic behavior also see #75 |
|
Creating a work-around for a work-around is not a good idea, closing in favor of patching the sleuthkit source #102 |
|
Ah thank you that'll work as well @joachimmetz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Programs may rely on a consistent, non-UTC timezone, for logging / other behaviors. When pytsk3 is imported, this code will may change the timezone in the middle of a program run which has adverse effects. I do understand this is to correct libtsk behavior, however, this is a way to opt-out of the forced tzset and handle libtsk's timestamp behavior separately.