Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! First of all, thank you for this library. It is my first time using it, and thanks to the IDE I discovered that there was an
image
parameter in theprovisioning_uri
method. Also, looking at the source code I discovered that it consisted of a URL.In this PR, the
image
parameter is defined explicitly in all the methods involved and added some documentation for it. I also added some missing documentation for methods such asbyte_secret
orprovisioning_uri
(from theTOTP
class).I also considered it was good to document that the
digits
parameter in theSteam
class is discarded and hardcoded to10
. So I added this clarification and changed the default value to make it more intuitive to the naked eye.Finally, I standardized a little bit, adding the missing dots in sentences, I documented a
:return
and corrected a typo.I remain pending if you consider that other changes should be made. Greetings!