Disable run button when running #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelcolvin
reviewed
Feb 4, 2025
Jamie-Chang
had a problem deploying
to
deploy-preview
GitHub Actions
Failure
samuelcolvin
reviewed
Feb 6, 2025
src/frontend/src/app.tsx
Outdated
| @@ -75,7 +78,7 @@ export default function () { | |||
| </aside> | |||
| </header> | |||
| <section> | |||
| <Editor runCode={runCode} /> | |||
| <Editor runCode={runCode} running={running} /> | |||
There was a problem hiding this comment.
Suggested change
| <Editor runCode={runCode} running={running} /> | |
| <Editor runCode={runCode} running={running()} /> |
Ah I see what you mean now, thanks! |
|
thanks so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big fan of your project!
Noticed that you can spam click run and that'll run the code multiple times concurrently.
So I've opportunistically made a small change to disable the run button while pyodide worker is running.